We explored the associations between student-perceived teaching behaviours and negative affect (NA) and positive affect (PA) in upper elementary age students, both before and after controlling for perceived parenting behaviours. The Teaching Behaviour Questionnaire, the Alabama Parenting Questionnaire, and the Positive and Negative Affect Schedule for Children were completed by 777 third to fifth graders in nine elementary schools. Using two-level hierarchical linear model analyses, we found that (a) perceived instructional teaching behaviour was negatively associated with NA and positively associated with PA; (b) perceived organizational behaviour was not associated with either; (c) perceived socio-emotional teaching behaviour was positively associated with both; (d) perceived negative teaching behaviour was positively associated with NA but not associated with PA. When parenting behaviours were controlled for, the associations with NA but not with PA held up. We discuss the implications of the findings for education and mental health personnel.