Teachers' professional development and learning is of high interest in educational reform internationally. We present findings from the "State of Educators' Professional Learning in Canada" study. We identify ten features proposed for effective professional learning: evidence-informed subject specific and pedagogical content knowledge a focus on student outcomes a balance of teacher voice and system coherence active and variable learning collaborative learning experiences job-embedded learning ongoing in duration resources and supportive and engaged leadership. Our findings indicate that these features are present in current professional learning experiences within Canada. However, we also found important differences in the details of professional learning within and across Canada. We suggest it is important to research, value and understand the diversity of professional learning needs, activities, experiences and outcomes within and across countries. We discuss potential considerations for the study of teachers' professional learning in Scotland to contribute to improvements locally and to inform global debates.