All knowledge is socially constructed, including physical education teachers' knowledge of their subject. It is acquired from other people either formally and deliberately (e.g. by being taught) or informally and casually (e.g. by interacting with physical education teachers or playing in a sports team). The social aspects of learning appear to be particularly strong in physical education. This has implications for the development of knowledge for teaching, with trainee teachers focusing on the development of subject, and particularly content, knowledge. Focusing on subject knowledge reinforces a traditional view of physical education as it is, not as it might be to meet the needs of young people today. It is argued that attention needs to be given not only to the knowledge, skills and competencies that trainee teachers ought to develop but also to the social aspects of their learning and development and the context in which they learn. Attention also needs to be given to how the ability to think critically can be developed so that trainee teachers can become reflective practitioners able to challenge and, where appropriate, change the teaching of the subject. Only by doing this can the particularly strong socialization which shapes the values and beliefs of physical education teachers begin to be challenged. However, as the process of developing knowledgeable teachers is ongoing it is also necessary to look beyond teacher training to continuing professional development.