This paper discusses some of the findings from a 3-year longitudinal study of language learning in the upper stage of English primary schools, i.e. at Key Stage 2. This largely qualitative study (commissioned by the then Department for Children, Schools and Families) was designed to explore and document developing provision and practice in a sample of primary schools that had chosen to introduce language teaching ahead of the proposal that it should become part of statutory requirements. The research team examined the approaches and mechanisms these schools were using to develop and maintain language learning and teaching, teachers' and children's attitudes towards language learning and children's achievement in oracy and literacy, as well as considering the possible broader cross-curricular impact of language learning. This paper goes on to consider some of the implications for embedding language learning and teaching in English primary schools.