The authors investigated the impact of 22 pre-service teachers' participation in a change-oriented service-learning project on their conceptions of citizenship as civic actors and civic educators. The goal of this project was to push students toward adopting more critically conscious and activist conceptions of citizenship as aligned with the needs of a democratic society. Using Eyler and Giles' (1999) typology of effective citizenship as an analytic framework, we describe how students' participation in this project led to demonstrated growth along all five dimensions of effective citizenship. Yet, analysis revealed that, despite the project's change-orientation, students' conceptions of citizenship failed to move beyond personal responsibility to include enhanced social consciousness and the importance of collective action. Thus, we raise critical questions about what constitutes "effective citizenship" in a democratic society and the role of higher education in preparing teachers to embody and enact such a vision.