With career-long professional learning increasingly seen as a significant element of teacher education, this paper proposes that there is a need to acknowledge the complex nature of the professional learning process. The paper explores lessons learnt from over a decade of professional learning efforts by the Developmental Physical Education Group at The University of Edinburgh. With the group's traditional initial continuing professional development efforts having limited impact on teachers' practice, the paper considers how more recent efforts have refocused on a longer term, participative and situated approach that appears to be having significantly more influence on teachers as professional learners.