There has been a considerable amount of work on what knowledge student teachers need to develop to become effective teachers. The purpose of this study was to look at the development of knowledge of student physical education teachers in England. Six secondary student physical education teachers completed a journal on a monthly basis throughout their one-year course. The student teachers and their mentors were interviewed in school towards the end of their course in June. Responses were analysed inductively. Results showed that knowledge important to develop, knowledge developed and knowledge which still needs to be developed at the end of the course was all related to content knowledge and pedagogical knowledge which they could apply in the immediate practical teaching situation. The results are discussed in relation to the development of student physical education teachers knowledge for teaching.