Used a national probability sample of 1,027 mathematics and science teachers to provide a large-scale empirical comparison of effects of different characteristics of professional development on teachers' learning. Results identify three core features of professional development that have significant positive effects on teachers' self-reported increases in knowledge and skills and changes in classroom practice. Also identifies structures that affect teacher learning. (SLD)